[PATCH libdrm 2/2] tegra: update symbol-check

[Emil Velikov]

On 3 April 2017 at 21:55, Erik Faye-Lund <kusmabite at gmail.com> wrote:
> On Mon, Apr 3, 2017 at 6:59 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 29 March 2017 at 23:24, Erik Faye-Lund <kusmabite at gmail.com> wrote:
>>> I get a few more symbols in my build tegra-libraries, so let's
>>> include these in the whitelist as well.
>>>
>>> While we're at it, update the comment at the top.
>>>
>>> Signed-off-by: Erik Faye-Lund <kusmabite at gmail.com>
>> R-B and pushed to master.
>>
>> Out of curiosity:
>> What platform are you using that introduces these - musl, newer glibc, other ?
>
> I'm using glibc 2.25 (in particular, 2.25-1 from Arch Linux).
>
Using up-to date Arch with glibc 2.25-1 and symbols are not there.
Perhaps you're using the ARM one ... either way it doesn't matter that
much.

>> Would be great if we can strip platform specific symbols from the list
>> - do you have any ideas how we can do that ?
>> We could omit any symbols that start with __ but that does not sound too robust.
>
> I think ignoring anything that starts with both single and double
> underscore would make sense, as those symbols are reserved by the
> compiler and "implementation" (typically libc etc). Our API shouldn't
> export these symbols in the first place, and I suspect code-review is
> sufficient to ensure this.
>
> But either way, I'd prefer to just get the test working again first.

Agreed. The patch is in master and part of 2.4.77

-Emil