[PATCH 12/15] drm: Add acquire ctx to ->gamma_set hook

Daniel Vetter daniel.vetter at ffwll.ch
Thu Apr 6 18:00:39 UTC 2017

On Thu, Apr 6, 2017 at 6:51 PM, Eric Anholt <eric at anholt.net> wrote:
> Daniel Vetter <daniel.vetter at ffwll.ch> writes:
>> Atomic helpers really want this instead of the hacked-up legacy
>> backoff trick, which unfortunately prevents drivers from using their
>> own private drm_modeset_locks.
>> Aside: There's a few atomic drivers (nv50, vc4, soon vmwgfx) which
>> don't yet use the new atomic color mgmt/gamma table stuff. Would be
>> nice if they could switch over and just hook up
>> drm_atomic_helper_legacy_gamma_set() instead.
> For notes like this, it would be helpful to have a pointer to a driver
> doing it cleanly the current way.

Yeah, good point. And the kernel-doc for legacy_gamma_set is also not
all that awesome. So we currently have i915, mediatek and omapdrm
using this, and for the new atomic gamma stuff we do have fairly
reasonable docs (just a bit harder to find that I thought they'd be):

I'll try and type up a patch to sprinkle a few more hints around and
connect the pieces.
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

More information about the dri-devel mailing list