[Intel-gfx] [PATCH] drm: Fix get_property logic fumble

Daniel Vetter daniel at ffwll.ch
Wed Apr 12 15:18:38 UTC 2017

On Mon, Apr 10, 2017 at 01:37:01PM +0100, Chris Wilson wrote:
> On Mon, Apr 10, 2017 at 01:54:45PM +0200, Daniel Vetter wrote:
> > Yet again I've proven that I can't negate conditions :(
> > 
> > Fixes: eb8eb02ed850 ("drm: Drop modeset_lock_all from the getproperty ioctl")
> You also get to write the igt/kms_getproperty, starting with a 
> 	memset(prop_values, 0xc5, foo);
> 	drmIoctl(GETPROPERTY);
> 	igt_assert(!memchr(prop_values, 0xc5, bar));

Testcase: igt/kms_properties/get_property-sanity

Thanks for reminding me to not be lazy with testing stuff we've broken!

Pushed the patch to -next-fixes.

Cheers, Daniel
Daniel Vetter
Software Engineer, Intel Corporation

More information about the dri-devel mailing list