[PATCH] drm/vc4: Add runtime PM support to the HDMI encoder driver

Eric Anholt eric at anholt.net
Fri Apr 14 18:20:52 UTC 2017

Boris Brezillon <boris.brezillon at free-electrons.com> writes:

> The HDMI driver is currently enabling all clks and probe time and keep
> the power-domain connected to the HDMI encoder enabled.

How about "The HDMI driver is currently enabling all clocks at probe
time and keeps the power domain..."?

> Move all activation code to vc4_hdmi_encoder_enable() and make sure
> the clks and power domain are released when the HDMI encoder is not used
> by adding deactivation steps in vc4_hdmi_encoder_disable().
> Note that the sequencing imposed by the IP requires that we move
> vc4_hdmi_encoder_mode_set() code into vc4_hdmi_encoder_enable().

I'm quite happy to see _mode_set() gone.

I'm hoping to go through a bunch of mode switching testing with this
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170414/12303ef0/attachment.sig>

More information about the dri-devel mailing list