[PATCH] drm/vc4: Add runtime PM support to the HDMI encoder driver

Eric Anholt eric at anholt.net
Tue Apr 18 21:34:45 UTC 2017

Boris Brezillon <boris.brezillon at free-electrons.com> writes:

> On Fri, 14 Apr 2017 11:20:52 -0700
> Eric Anholt <eric at anholt.net> wrote:
>> Boris Brezillon <boris.brezillon at free-electrons.com> writes:
>> > The HDMI driver is currently enabling all clks and probe time and keep
>> > the power-domain connected to the HDMI encoder enabled.  
>> How about "The HDMI driver is currently enabling all clocks at probe
>> time and keeps the power domain..."?
> Yep.
>> > Move all activation code to vc4_hdmi_encoder_enable() and make sure
>> > the clks and power domain are released when the HDMI encoder is not used
>> > by adding deactivation steps in vc4_hdmi_encoder_disable().
>> >
>> > Note that the sequencing imposed by the IP requires that we move
>> > vc4_hdmi_encoder_mode_set() code into vc4_hdmi_encoder_enable().  
>> I'm quite happy to see _mode_set() gone.
>> I'm hoping to go through a bunch of mode switching testing with this
>> Monday.
> Ok, cool. Let me know if you have any problem.

I did a whole bunch of modesets today and things seemed good.  VEC
didn't turn on when I switched to it, but switching back to HDMI worked,
which didn't before.

Reviewed and pushed.  Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170418/3141c467/attachment.sig>

More information about the dri-devel mailing list