[PATCH 3/6] drm/bridge: tc358767: fix DP0_MISC register set
Philipp Zabel
p.zabel at pengutronix.de
Tue Aug 1 13:11:33 UTC 2017
On Thu, 2017-07-27 at 15:47 +0300, Andrey Gusakov wrote:
> Remove shift from TU_SIZE_RECOMMENDED define as it used to
> calculate max_tu_symbols.
>
> Signed-off-by: Andrey Gusakov <andrey.gusakov at cogentembedded.com>
> ---
> drivers/gpu/drm/bridge/tc358767.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index e8008e0c2e88..4aee6178d889 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -97,7 +97,7 @@
> #define DP0_ACTIVEVAL 0x0650
> #define DP0_SYNCVAL 0x0654
> #define DP0_MISC 0x0658
> -#define TU_SIZE_RECOMMENDED (0x3f << 16) /* LSCLK cycles per TU */
> +#define TU_SIZE_RECOMMENDED (63) /* LSCLK cycles per TU */
> #define BPC_6 (0 << 5)
> #define BPC_8 (1 << 5)
>
> @@ -716,7 +716,8 @@ static int tc_set_video_mode(struct tc_data *tc, struct drm_display_mode *mode)
> * Must be less than tu_size.
> */
> max_tu_symbol = TU_SIZE_RECOMMENDED - 1;
> - tc_write(DP0_MISC, (max_tu_symbol << 23) | TU_SIZE_RECOMMENDED | BPC_8);
> + tc_write(DP0_MISC, (max_tu_symbol << 23) | (TU_SIZE_RECOMMENDED << 16) |
> + BPC_8);
>
> return 0;
> err:
Acked-by: Philipp Zabel <p.zabel at pengutronix.de>
regards
Philipp
More information about the dri-devel
mailing list