[PATCH] drm/omap: Rework the rotation-on-crtc hack

[Daniel Vetter]

On Fri, Aug 4, 2017 at 11:57 AM, Tomi Valkeinen <tomi.valkeinen at ti.com> wrote:
>> Here you go, compile tested version. :)
>> ----8<----
>> I want/need to rework the core property handling, and this hack is
>> getting in the way. But since it's a non-standard propety only used by
>> legacy userspace we know that this will only every be called from
>> ioctl code. And never on some other free-standing state struct, where
>> this old hack wouldn't work either.
>>
>> v2: don't forget zorder and get_property!
>>
>> v3: Shadow the legacy state to avoid locking issues in get_property
>> (Maarten).
>>
>> v4: Review from Laurent
>> - Move struct omap_crtc_state into omap_crtc.c
>> - Clean up comments.
>> - Don't forget to copy the shadowed state over on duplicate.
>>
>> v5: Don't forget to update the reset handler (Maarten).
>> v6: Update omap_crtc_state shadow values in omap_crtc_atomic_check (Maarten).
>>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com> (v4)
>> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> Cc: Tomi Valkeinen <tomi.valkeinen at ti.com
>> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> ---
>>  drivers/gpu/drm/omapdrm/omap_crtc.c | 118 +++++++++++++++++++++++++-----------
>>  1 file changed, 81 insertions(+), 37 deletions(-)
>
> This makes all the CRTC properties disappear...

Strange, we should still register them, that's really surprising.

> This doesn't depend on anything in drm-next, does it? I'm currently on
> v4.13-rc3. I'll look a bit more on what's going on later today.

Not that I know of. Later patches will, but this one should be stand-alone.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch