[PATCH v7] drm/omap: Rework the rotation-on-crtc hack

[Tomi Valkeinen]

On 07/08/17 13:20, Maarten Lankhorst wrote:

> I want/need to rework the core property handling, and this hack is
> getting in the way. But since it's a non-standard propety only used by
> legacy userspace we know that this will only every be called from
> ioctl code. And never on some other free-standing state struct, where
> this old hack wouldn't work either.
> 
> v2: don't forget zorder and get_property!
> 
> v3: Shadow the legacy state to avoid locking issues in get_property
> (Maarten).
> 
> v4: Review from Laurent
> - Move struct omap_crtc_state into omap_crtc.c
> - Clean up comments.
> - Don't forget to copy the shadowed state over on duplicate.
> 
> v5: Don't forget to update the reset handler (Maarten).
> v6: Update omap_crtc_state shadow values in omap_crtc_atomic_check (Maarten).
> v7:
> - Fix get_property to return 0 and set value in *val (Maarten).
> - Update comment in set_property for changes in v6 (Maarten).
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com> (v4)
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Tomi Valkeinen <tomi.valkeinen at ti.com
> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> ---
>  drivers/gpu/drm/omapdrm/omap_crtc.c | 124 ++++++++++++++++++++++++------------
>  1 file changed, 85 insertions(+), 39 deletions(-)

Thanks, works now.

Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ti.com>

 Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170808/4caad636/attachment.sig>