[maintainer-tools PATCH 7/7] dim: protect against escaped chars when reading cc'ed emails

Eric Engestrom eric.engestrom at imgtec.com
Wed Aug 9 11:11:01 UTC 2017


Suggested by shellcheck (`make check`).

Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
---
 dim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dim b/dim
index 2e22fefa8867..75ce55188af4 100755
--- a/dim
+++ b/dim
@@ -2002,7 +2002,7 @@ function dim_add_missing_cc
 		return
 	fi
 
-	git show | scripts/get_maintainer.pl --email --norolestats --pattern-depth 1 | while read cc; do
+	git show | scripts/get_maintainer.pl --email --norolestats --pattern-depth 1 | while read -r cc; do
 		email="$(email_get_address "$cc")"
 		name="$(email_get_name "$cc")"
 
-- 
Cheers,
  Eric



More information about the dri-devel mailing list