[Intel-gfx] [maintainer-tools PATCH 2/7] dim: fix end-of-line in regex
Jani Nikula
jani.nikula at intel.com
Wed Aug 9 12:57:05 UTC 2017
On Wed, 09 Aug 2017, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
> dim | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dim b/dim
> index af1baa11c7b2..eaabcec43c8f 100755
> --- a/dim
> +++ b/dim
> @@ -1970,7 +1970,7 @@ function dim_add_missing_cc
> name=''
>
> if echo "$cc" | grep -q '<'; then
> - name="$(echo ${cc/<*/} | sed -e 's/[[:space:]]*\$//')";
> + name="$(echo ${cc/<*/} | sed -e 's/[[:space:]]*$//')";
What's the failure mode? It never nukes trailing space after all? Please
say so in the commit message.
BR,
Jani.
> fi
>
> # Don't add main mailing lists
> @@ -1988,7 +1988,7 @@ function dim_add_missing_cc
> if [ "$testemail" != "$email" ]; then
> if [ -z "$name" ]; then continue; fi
>
> - testname="$(echo ${testcc/<*/} | sed -e 's/[[:space:]]*\$//' -e 's/^[[:space:]]*//')"
> + testname="$(echo ${testcc/<*/} | sed -e 's/[[:space:]]*$//' -e 's/^[[:space:]]*//')"
>
> if [ "$testname" != "$name" ]; then continue; fi
> fi
--
Jani Nikula, Intel Open Source Technology Center
More information about the dri-devel
mailing list