[PATCH] drm: Shift wrap bug in create_in_format_blob()

Daniel Stone daniel at fooishbar.org
Wed Aug 9 14:38:33 UTC 2017


On 9 August 2017 at 15:36, Sean Paul <seanpaul at chromium.org> wrote:
> On Wed, Aug 09, 2017 at 02:19:06PM +0300, Dan Carpenter wrote:
>> "plane->format_count" can go up to 64.  (It's capped in
>> drm_universal_plane_init().)  So we should be using ULL type instead of
>> int here to prevent shift wrapping.
>>
>> Fixes: db1689aa61bd ("drm: Create a format/modifier blob")
>> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>
> Thank you for the fix, Dan.
>
> I've applied it to drm-misc-next.

Yes, thanks Dan!

Out of interest, how was this found? With sparse?

Cheers,
Daniel


More information about the dri-devel mailing list