[PATCH v2 18/19] drm/virtio: Use the drm_driver.dumb_destroy default

[Daniel Vetter]

On Sun, Aug 06, 2017 at 05:41:07PM +0200, Noralf Trønnes wrote:
> virtio_gpu_mode_dumb_destroy() is the same as drm_gem_dumb_destroy()
> which is the drm_driver.dumb_destroy default, so no need to set it.
> 
> Cc: David Airlie <airlied at linux.ie>
> Cc: Gerd Hoffmann <kraxel at redhat.com>
> Signed-off-by: Noralf Trønnes <noralf at tronnes.org>
> ---
>  drivers/gpu/drm/virtio/virtgpu_drv.c | 1 -
>  drivers/gpu/drm/virtio/virtgpu_drv.h | 3 ---
>  drivers/gpu/drm/virtio/virtgpu_gem.c | 7 -------
>  3 files changed, 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c
> index 63d35c7..49a3d8d 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_drv.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c
> @@ -122,7 +122,6 @@ static struct drm_driver driver = {
>  
>  	.dumb_create = virtio_gpu_mode_dumb_create,
>  	.dumb_map_offset = virtio_gpu_mode_dumb_mmap,

Like cirrus&co (they're all copypasted from each another) the map_offset
one could be replaced by the generic one too.
-Daniel

> -	.dumb_destroy = virtio_gpu_mode_dumb_destroy,
>  
>  #if defined(CONFIG_DEBUG_FS)
>  	.debugfs_init = virtio_gpu_debugfs_init,
> diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h
> index 3a66abb..da2fb58 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_drv.h
> +++ b/drivers/gpu/drm/virtio/virtgpu_drv.h
> @@ -236,9 +236,6 @@ struct virtio_gpu_object *virtio_gpu_alloc_object(struct drm_device *dev,
>  int virtio_gpu_mode_dumb_create(struct drm_file *file_priv,
>  				struct drm_device *dev,
>  				struct drm_mode_create_dumb *args);
> -int virtio_gpu_mode_dumb_destroy(struct drm_file *file_priv,
> -				 struct drm_device *dev,
> -				 uint32_t handle);
>  int virtio_gpu_mode_dumb_mmap(struct drm_file *file_priv,
>  			      struct drm_device *dev,
>  			      uint32_t handle, uint64_t *offset_p);
> diff --git a/drivers/gpu/drm/virtio/virtgpu_gem.c b/drivers/gpu/drm/virtio/virtgpu_gem.c
> index cc025d8..72ad7b1 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_gem.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_gem.c
> @@ -118,13 +118,6 @@ int virtio_gpu_mode_dumb_create(struct drm_file *file_priv,
>  	return ret;
>  }
>  
> -int virtio_gpu_mode_dumb_destroy(struct drm_file *file_priv,
> -				 struct drm_device *dev,
> -				 uint32_t handle)
> -{
> -	return drm_gem_handle_delete(file_priv, handle);
> -}
> -
>  int virtio_gpu_mode_dumb_mmap(struct drm_file *file_priv,
>  			      struct drm_device *dev,
>  			      uint32_t handle, uint64_t *offset_p)
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch