[PATCH 02/14] drm/cirrus: unregister connector on destroy

Varad Gautam varadgautam at gmail.com
Sat Aug 19 06:10:20 UTC 2017


Discard this one, not needed in light of [1]:

"drm_dev_unregister unregisters all connectors too. Explicitly calling
drm_connector_unregister should only be needed when you
a) screwed up your unload sequence. Get rid of ->unload and make sure you
call drm_dev_unregister first to fix this properly
b) hot-unplug. Doesn't apply to cirrus."

[1] http://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg191644.html

Thanks,
Varad

On Fri, Aug 18, 2017 at 9:19 PM, Varad Gautam <varadgautam at gmail.com> wrote:
> From: Varad Gautam <varad.gautam at collabora.com>
>
> add missing unregister call on connector destroy.
>
> Signed-off-by: Varad Gautam <varad.gautam at collabora.com>
> ---
>  drivers/gpu/drm/cirrus/cirrus_mode.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c
> index 21d75e7e4abc..6032978a2797 100644
> --- a/drivers/gpu/drm/cirrus/cirrus_mode.c
> +++ b/drivers/gpu/drm/cirrus/cirrus_mode.c
> @@ -492,6 +492,7 @@ static struct drm_encoder *cirrus_connector_best_encoder(struct drm_connector
>
>  static void cirrus_connector_destroy(struct drm_connector *connector)
>  {
> +       drm_connector_unregister(connector);
>         drm_connector_cleanup(connector);
>         kfree(connector);
>  }
> --
> 2.13.1
>


More information about the dri-devel mailing list