[PATCH libdrm v3 1/2] etnaviv: fix etna_bo_from_name
Eric Engestrom
eric.engestrom at imgtec.com
Mon Aug 21 13:09:44 UTC 2017
On Monday, 2017-08-21 14:41:11 +0200, Philipp Zabel wrote:
> Look up BOs from the name table using the name parameter instead of
> req.handle (which at this point is always zero).
>
> Signed-off-by: Philipp Zabel <p.zabel at pengutronix.de>
> Reviewed-by: Eric Engestrom <eric at engestrom.ch>
> Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>
> Reviewed-by: Wladimir J. van der Laan <laanwj at gmail.com>
> Reviewed-by: Daniel Stone <daniels at collabora.com>
> ---
> v3: added review tag
That list kept growing, so I checked and I saw you don't have commit
access; you should have said something :P
I pushed this patch now.
I don't know enough to review etna_bo_from_handle and the deadlock
patch is quite new, so I'm letting these two sit for now, but please
ping someone when you need your patches to be pushed ;)
> ---
> etnaviv/etnaviv_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/etnaviv/etnaviv_bo.c b/etnaviv/etnaviv_bo.c
> index 4ad0434e..4fe877f1 100644
> --- a/etnaviv/etnaviv_bo.c
> +++ b/etnaviv/etnaviv_bo.c
> @@ -173,7 +173,7 @@ struct etna_bo *etna_bo_from_name(struct etna_device *dev, uint32_t name)
> pthread_mutex_lock(&table_lock);
>
> /* check name table first, to see if bo is already open: */
> - bo = lookup_bo(dev->name_table, req.handle);
> + bo = lookup_bo(dev->name_table, name);
> if (bo)
> goto out_unlock;
>
> --
> 2.11.0
>
More information about the dri-devel
mailing list