[Bug 102342] mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style) Suspicious condition

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=102342

            Bug ID: 102342
           Summary: mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.
                    c:169]: (style) Suspicious condition
           Product: Mesa
           Version: 17.1
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel at lists.freedesktop.org
          Reporter: dcb314 at hotmail.com
        QA Contact: dri-devel at lists.freedesktop.org

mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style)
Suspicious condition (assignment + comparison); Clarify expression with
parentheses.

Source code is

      if (!entry && (ret = pb_cache_is_buffer_compat(cur_entry, size,
                                                     alignment, usage) > 0))

maybe better code

      if (!entry && ((ret = pb_cache_is_buffer_compat(cur_entry, size,
                                                     alignment, usage)) > 0))

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170821/0f2cc1dc/attachment.html>