[PATCH v4 4/4] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

Hans de Goede hdegoede at redhat.com
Tue Aug 22 10:05:55 UTC 2017


Hi,

On 22-08-17 11:00, Imre Deak wrote:
> On Sun, Aug 20, 2017 at 02:59:20PM +0200, Hans de Goede wrote:

<snip>

>> diff --git a/arch/x86/platform/intel/iosf_mbi.c b/arch/x86/platform/intel/iosf_mbi.c
>> index a952ac199741..a5361fd11e6e 100644
>> --- a/arch/x86/platform/intel/iosf_mbi.c
>> +++ b/arch/x86/platform/intel/iosf_mbi.c
>> @@ -218,19 +218,15 @@ int iosf_mbi_register_pmic_bus_access_notifier(struct notifier_block *nb)
>>   }
>>   EXPORT_SYMBOL(iosf_mbi_register_pmic_bus_access_notifier);
>>   
>> -int iosf_mbi_unregister_pmic_bus_access_notifier(struct notifier_block *nb)
>> +int iosf_mbi_unregister_pmic_bus_access_notifier_unlocked(
>> +	struct notifier_block *nb)
>>   {
>> -	int ret;
>> +	WARN_ON(!mutex_is_locked(&iosf_mbi_punit_mutex));
> 
> Missed to change this to iosf_mbi_assert_punit_acquired(). The rest
> looks ok to me. I can change the above while applying, no need to
> resend for this.

Cool, thank you.

Regards,

Hans


More information about the dri-devel mailing list