[PATCH 06/14] drm/cirrus: Use 32bpp by default

Varad Gautam varadgautam at gmail.com
Wed Aug 23 15:40:09 UTC 2017


Hi Matthew,

On Sat, Aug 19, 2017 at 2:02 PM, Matthew Garrett <mjg59 at srcf.ucam.org> wrote:
> On Fri, Aug 18, 2017 at 09:19:11PM +0530, Varad Gautam wrote:
>> From: Stéphane Marchesin <marcheu at chromium.org>
>>
>> initially reviewed for ChromiumOS at:
>> https://chromium-review.googlesource.com/339093
>> Signed-off-by: Stéphane Marchesin <marcheu at chromium.org>
>
> 1280x1024x24 fits in 4MB, 1280x1024x32 doesn't. That seems like it's
> going to be a visible change in behaviour.
>

Right, 800x600 is the highest we can go for >24bpp, so we now switch
to that instead of 1280x1024. fb creation fails in
cirrus_check_framebuffer if the w*h*bpp doesn't fit, and plane updates
get rejected when atomic is enabled later on.

Regards,
Varad

> --
> Matthew Garrett | mjg59 at srcf.ucam.org


More information about the dri-devel mailing list