[radeon-alex:drm-next-4.14-wip 39/44] drivers/gpu/drm/radeon/radeon_ttm.c:763:2: error: implicit declaration of function 'ttm_populate_and_map_pages'

Tom St Denis tom.stdenis at amd.com
Thu Aug 24 10:38:49 UTC 2017


On 24/08/17 02:43 AM, Christian König wrote:
> The problem is here:
>> #if defined(CONFIG_SWIOTLB) || defined(CONFIG_INTEL_IOMMU)
> ....
>> extern int ttm_dma_populate(struct ttm_dma_tt *ttm_dma, struct device 
>> *dev);
>> extern void ttm_dma_unpopulate(struct ttm_dma_tt *ttm_dma, struct 
>> device *dev);
> 
> We have forgotten to provide dummies for non SWIOTLB/IOMMU systems and 
> xtensa doesn't seem to have this.
> 
> And BTW please drop the "extern" keyword here, that is the default for 
> functions anyway.

The functions I added don't have extern.  That being said I can write 
two patches one that adds dummy functions and one that removes the 
needless externs.

Cheers,
Tom


More information about the dri-devel mailing list