[PATCH] drm/tve200: Pass NULL format_modifier to drm_simple_display_pipe_init

Daniel Vetter daniel at ffwll.ch
Mon Aug 28 08:40:34 UTC 2017


On Fri, Aug 25, 2017 at 01:16:12PM -0700, Rodrigo Vivi wrote:
> This Fixes build on branches where we already have format-modifier.
> 
> Reference: https://lists.freedesktop.org/archives/dri-devel/2017-August/151044.html
> Fixes: e6fc3b68558e ("drm: Plumb modifiers through plane init")

tve200 was merged after this patch, the correct Fixes line would be:

Fixes: 179c02fe90a4 ("drm/tve200: Add new driver for TVE200")

Linus, can you pls make sure that tve200 is enabled int the
drm-rerere/*arm*defconfig files, to avoid this in the future? They're the
recommended set to compile-test drm-misc (yes we should somehow bot-ify
this, but oh well).

Thanks, Daniel

> Cc: Linus Walleij <linus.walleij at linaro.org>
> Cc: Janet Morgan <janet.morgan at intel.com>
> Cc: Ben Widawsky <ben at bwidawsk.net>
> Cc: Daniel Stone <daniels at collabora.com> (v2)
> Cc: Liviu Dudau <Liviu.Dudau at arm.com>
> Cc: Daniel Stone <daniels at collabora.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
>  drivers/gpu/drm/tve200/tve200_display.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/tve200/tve200_display.c b/drivers/gpu/drm/tve200/tve200_display.c
> index 37fb333331f3..3f4b97bf2a13 100644
> --- a/drivers/gpu/drm/tve200/tve200_display.c
> +++ b/drivers/gpu/drm/tve200/tve200_display.c
> @@ -336,6 +336,7 @@ int tve200_display_init(struct drm_device *drm)
>  	ret = drm_simple_display_pipe_init(drm, &priv->pipe,
>  					   &tve200_display_funcs,
>  					   formats, ARRAY_SIZE(formats),
> +					   NULL,
>  					   &priv->connector.connector);
>  	if (ret)
>  		return ret;
> -- 
> 2.13.2
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list