[PATCH] drm/tve200: Pass NULL format_modifier to drm_simple_display_pipe_init

[Linus Walleij]

On Wed, Aug 30, 2017 at 9:22 AM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Mon, Aug 28, 2017 at 10:40:34AM +0200, Daniel Vetter wrote:
>> On Fri, Aug 25, 2017 at 01:16:12PM -0700, Rodrigo Vivi wrote:
>> > This Fixes build on branches where we already have format-modifier.
>> >
>> > Reference: https://lists.freedesktop.org/archives/dri-devel/2017-August/151044.html
>> > Fixes: e6fc3b68558e ("drm: Plumb modifiers through plane init")
>>
>> tve200 was merged after this patch, the correct Fixes line would be:
>>
>> Fixes: 179c02fe90a4 ("drm/tve200: Add new driver for TVE200")
>>
>> Linus, can you pls make sure that tve200 is enabled int the
>> drm-rerere/*arm*defconfig files, to avoid this in the future? They're the
>> recommended set to compile-test drm-misc (yes we should somehow bot-ify
>> this, but oh well).

Oh I was not aware of that, sorry.

> Neither Rodrigo (as the author of the patch) or Linus (as the driver
> maintainer) took action here already, and since it's an obvious compile
> fail it's annoying, so I merged it.

Thanks.

> But really this entire commit rights thing means committer take care of
> this stuff, not maintainers.
>
> Linus, I also added tve200 to the defconfigs now.

Thanks, I was just about to ask how to do it.

I will look in drm-rerere folder and try to figure out how this works so
I can get it right in the future.

Yours,
Linus Walleij