[PATCH v3 4/4] DTS: Pandora: fix panel compatibility string
tomi.valkeinen at ti.com
Fri Dec 1 08:13:24 UTC 2017
On 01/12/17 00:06, Sebastian Reichel wrote:
>>>> How about let's call it a "typo fix" then? :)
>>> Well, it is not really a typo.
>> Well what if the stable people pick it into earlier stable series
>> based on the word fix in the subject? That has happened before.
>> I suggest you update the dts patches to use wording like
>> "update compatible to use new naming" or something similar.
> Patch 4/4 is a Fix and should be applied to stable trees. "omapdss,"
> prefix was never supposed to be in the DTS files, is not supposed to
> be in there now and will break some time in the future.
> Explanation: The early init of omapdss adds the prefix at runtime,
> so that the binding can use generic properties and the kernel can
> use omapdss specific drivers until the generic ones can be used
This is true, but the extra "omapdss" does not cause any issues at the
moment, and the time when it causes issues is still many kernel versions
in the future.
But, yes, thinking about this, I agree, it's better to pick this one
separately as a fix (after rebasing it on top of current maineline so
that it doesn't depend on the toppoly name change), and leaving the
toppoly->tpo change as a cleanup.
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
More information about the dri-devel