[PATCH v3 05/15] drm/sun4i: Fix error path handling
wens at csie.org
Tue Dec 5 15:42:35 UTC 2017
On Tue, Dec 5, 2017 at 11:10 PM, Maxime Ripard
<maxime.ripard at free-electrons.com> wrote:
> The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap
> initialization sequence") moved a bunch of logic around, but forgot to
> update the gotos after the introduction of the err_free_dotclock label.
> It means that if we fail later that the one introduced in that commit,
> we'll just to the old label which isn't free the clock we created. This
> will result in a breakage as soon as someone tries to do something with
> that clock, since its resources will have been long reclaimed.
> Cc: <stable at vger.kernel.org>
> Fixes: 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence")
> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
I think this was reported, or I noticed it after the patch was merged,
but then I got busy with other stuff.
Reviewed-by: Chen-Yu Tsai <wens at csie.org>
More information about the dri-devel