[PATCH] drm/vmwgfx_kms: Fix potential NULL pointer dereference

Gustavo A. R. Silva garsilva at embeddedor.com
Tue Dec 5 15:47:13 UTC 2017

Hi Ville,

Quoting Ville Syrjälä <ville.syrjala at linux.intel.com>:

> On Mon, Dec 04, 2017 at 03:54:18PM -0600, Gustavo A. R. Silva wrote:
>> crtc_state is being null checked in a previous code block, which implies
>> that such pointer might be null.
>> crtc_state is dereferenced in drm_atomic_helper_check_plane_state, hence
>> there is a potential null pointer dereference.
> This is a false positive. drm_atomic_helper_check_plane_state() will not
> dereference crtc_state when plane_state->crtc is NULL.

You are right.

Thank you for clarifying.
Gustavo A. R. Silva

More information about the dri-devel mailing list