[PATCH 12/27] drm/etnaviv: hold GPU lock while inserting END command

Christian Gmeiner christian.gmeiner at gmail.com
Mon Dec 11 10:48:27 UTC 2017


2017-12-01 11:36 GMT+01:00 Lucas Stach <l.stach at pengutronix.de>:
> Inserting the END command when suspending the GPU is changing the
> command buffer state, which requires the GPU to be held.
>
> Signed-off-by: Lucas Stach <l.stach at pengutronix.de>

Reviewed-by: Christian Gmeiner <christian.gmeiner at gmail.com>

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index 1e1e34adb07f..85f6ee1da016 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1631,7 +1631,9 @@ static int etnaviv_gpu_hw_suspend(struct etnaviv_gpu *gpu)
>  {
>         if (gpu->buffer) {
>                 /* Replace the last WAIT with END */
> +               mutex_lock(&gpu->lock);
>                 etnaviv_buffer_end(gpu);
> +               mutex_unlock(&gpu->lock);
>
>                 /*
>                  * We know that only the FE is busy here, this should
> --
> 2.11.0
>



-- 
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info


More information about the dri-devel mailing list