[PATCH v3 08/15] drm/sun4i: Add LVDS support
maxime.ripard at free-electrons.com
Thu Dec 14 09:37:17 UTC 2017
On Thu, Dec 14, 2017 at 11:30:21AM +0800, Chen-Yu Tsai wrote:
> >> > + /* Map output pins to channel 0 */
> >> > + regmap_update_bits(tcon->regs, SUN4I_TCON_GCTL_REG,
> >> > + SUN4I_TCON_GCTL_IOMAP_MASK,
> >> > + SUN4I_TCON_GCTL_IOMAP_TCON0);
> >> > +
> >> > + /* Enable the output on the pins */
> >> > + regmap_write(tcon->regs, SUN4I_TCON0_IO_TRI_REG, 0xe0000000);
> >> Is this still needed? You are no longer using the TCON LCD pins
> >> with LVDS.
> > We do. It's a separate function of the pins, but it's the same pins.
> OK. I assume you've tried it without setting it and it failed?
> I just assume that these refer to the TCON LCD output, whereas
> LVDS looks like a separate module and function, and shouldn't
> need it.
Argh, I forgot to test that. I'll test it for real this time and will
update that part with a comment if that's needed.
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: not available
More information about the dri-devel