[PATCH v3 3/3] etnaviv: support performance monitor requests

Lucas Stach l.stach at pengutronix.de
Fri Dec 15 09:33:09 UTC 2017


Am Freitag, den 15.12.2017, 08:43 +0100 schrieb Christian Gmeiner:
> Add etna_cmd_stream_perf(..) to submit perform requests.
> Userspace can submit pmrs via submit ioctl to sample perfmon
> signals.
> 
> v3:
>  - mark perfmon bos as RW
> 
> Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
> ---

[...]

>  #endif /* ETNAVIV_DRMIF_H_ */
> diff --git a/etnaviv/etnaviv_priv.h b/etnaviv/etnaviv_priv.h
> index 7b289b61..e45d364c 100644
> --- a/etnaviv/etnaviv_priv.h
> +++ b/etnaviv/etnaviv_priv.h
> @@ -140,6 +140,10 @@ struct etna_cmd_stream_priv {
>  		/* reloc's table: */
>  		struct drm_etnaviv_gem_submit_reloc *relocs;
>  		uint32_t nr_relocs, max_relocs;
> +
> +		/* perf's table: */
> +		struct drm_etnaviv_gem_submit_pmr *pmrs;
> +		uint32_t nr_pmrs, max_pmrs;

On v2 I commented that I don't see max_pmrs used anywhere. If it's
unused please remove before pushing the patch.

Since this is a nitpick, you have my

Reviewed-by: Lucas Stach <l.stach at pengutronix.de>

Regards,
Lucas


More information about the dri-devel mailing list