[PATCH] staging: android: ion: Fix dma direction for dma_sync_sg_for_cpu/device

Laura Abbott labbott at redhat.com
Mon Dec 18 19:18:45 UTC 2017


On 12/15/2017 12:59 PM, Sushmita Susheelendra wrote:
> Use the direction argument passed into begin_cpu_access
> and end_cpu_access when calling the dma_sync_sg_for_cpu/device.
> The actual cache primitive called depends on the direction
> passed in.
> 

Acked-by: Laura Abbott <labbott at redhat.com>

> Signed-off-by: Sushmita Susheelendra <ssusheel at codeaurora.org>
> ---
>   drivers/staging/android/ion/ion.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index a7d9b0e..f480885 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -346,7 +346,7 @@ static int ion_dma_buf_begin_cpu_access(struct dma_buf *dmabuf,
>   	mutex_lock(&buffer->lock);
>   	list_for_each_entry(a, &buffer->attachments, list) {
>   		dma_sync_sg_for_cpu(a->dev, a->table->sgl, a->table->nents,
> -				    DMA_BIDIRECTIONAL);
> +				    direction);
>   	}
>   	mutex_unlock(&buffer->lock);
>   
> @@ -368,7 +368,7 @@ static int ion_dma_buf_end_cpu_access(struct dma_buf *dmabuf,
>   	mutex_lock(&buffer->lock);
>   	list_for_each_entry(a, &buffer->attachments, list) {
>   		dma_sync_sg_for_device(a->dev, a->table->sgl, a->table->nents,
> -				       DMA_BIDIRECTIONAL);
> +				       direction);
>   	}
>   	mutex_unlock(&buffer->lock);
>   
> 



More information about the dri-devel mailing list