[PATCH 6/7] drm/stm: ltdc: Remove unnecessary platform_get_resource() error check

Philippe CORNU philippe.cornu at st.com
Tue Dec 19 14:15:22 UTC 2017


Hi Fabio,


On 12/18/2017 02:02 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam at nxp.com>
> 
> devm_ioremap_resource() already checks if the resource is NULL, so
> remove the unnecessary platform_get_resource() error check.
> 
> Cc: Philippe Cornu <philippe.cornu at st.com>
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
> ---
>   drivers/gpu/drm/stm/ltdc.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 394613b..6dc5d4e 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -901,12 +901,6 @@ int ltdc_load(struct drm_device *ddev)
>   	}
>   
>   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		DRM_ERROR("Unable to get resource\n");
> -		ret = -ENODEV;
> -		goto err;
> -	}
> -

Many thanks for this cleanup.

Acked-by: Philippe Cornu <philippe.cornu at st.com>

Philippe :-)

>   	ldev->regs = devm_ioremap_resource(dev, res);
>   	if (IS_ERR(ldev->regs)) {
>   		DRM_ERROR("Unable to get ltdc registers\n");
> 


More information about the dri-devel mailing list