[RFC PATCH 42/60] hyper_dmabuf: always generate a new random keys

Dongwon Kim dongwon.kim at intel.com
Tue Dec 19 19:29:58 UTC 2017


From: Mateusz Polrola <mateuszx.potrola at intel.com>

Need to update random keys when reusing hyper_dmabuf_id
in the list to increase security

Signed-off-by: Dongwon Kim <dongwon.kim at intel.com>
---
 drivers/xen/hyper_dmabuf/hyper_dmabuf_id.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/hyper_dmabuf/hyper_dmabuf_id.c b/drivers/xen/hyper_dmabuf/hyper_dmabuf_id.c
index f59dee3..cccdc19 100644
--- a/drivers/xen/hyper_dmabuf/hyper_dmabuf_id.c
+++ b/drivers/xen/hyper_dmabuf/hyper_dmabuf_id.c
@@ -120,10 +120,11 @@ hyper_dmabuf_id_t hyper_dmabuf_get_hid(void)
 	 */
 	if (hid.id == -1 && count < HYPER_DMABUF_ID_MAX) {
 		hid.id = HYPER_DMABUF_ID_CREATE(hyper_dmabuf_private.domid, count++);
-		/* random data embedded in the id for security */
-		get_random_bytes(&hid.rng_key[0], 12);
 	}
 
+	/* random data embedded in the id for security */
+	get_random_bytes(&hid.rng_key[0], 12);
+
 	return hid;
 }
 
-- 
2.7.4



More information about the dri-devel mailing list