[RFC 0/3] drm/msm: Avoid subclassing of drm_atomic_state

Archit Taneja architt at codeaurora.org
Thu Dec 21 06:14:22 UTC 2017

It's been recommended that we use drm_private_objs embedded in
drm_atomic_state to hold shared resources instead of subclassing

This will also help us in getting one step closer to using the
atomic commit helpers instead of the msm_atomic_commit() funcs
in msm_atomic.c

I've taken the drm_private_obj usage in drm_dp_mst_topology as
reference. I've put this as RFC because I want others to see if
the private_obj stuff is used correctly.

Archit Taneja (3):
  drm/msm/mdp5: Add global state as a private atomic object
  drm/msm/mdp5: Use the new private_obj state
  drm/msm: Don't subclass drm_atomic_state anymore

 drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c   | 104 +++++++++++++++++++++---------
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h   |  29 +++++----
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_mixer.c |  12 ++--
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_pipe.c  |  20 +++---
 drivers/gpu/drm/msm/mdp/mdp5/mdp5_smp.c   |  17 +++--
 drivers/gpu/drm/msm/msm_atomic.c          |  31 ---------
 drivers/gpu/drm/msm/msm_drv.c             |   3 -
 drivers/gpu/drm/msm/msm_kms.h             |  14 ----
 8 files changed, 121 insertions(+), 109 deletions(-)

The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

More information about the dri-devel mailing list