[alsa-devel] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

Jidong Zhang jidong.zhang at hotmail.com
Wed Dec 20 07:19:24 UTC 2017

Does anyone know how to use Conexant CX20921 to develop our own application. I cannot find anywhere to download the software and manuals.

Thanks to all

-----Original Message-----
From: alsa-devel-bounces at alsa-project.org [mailto:alsa-devel-bounces at alsa-project.org] On Behalf Of Andy Shevchenko
Sent: 2017年12月20日 2:42
To: Joe Perches <joe at perches.com>
Cc: linux-fbdev at vger.kernel.org; David Airlie <airlied at linux.ie>; Joonas Lahtinen <joonas.lahtinen at linux.intel.com>; Heiko Carstens <heiko.carstens at de.ibm.com>; ALSA Development Mailing List <alsa-devel at alsa-project.org>; dri-devel at lists.freedesktop.org; Peter Ujfalusi <peter.ujfalusi at ti.com>; linux-s390 at vger.kernel.org; Linux OMAP Mailing List <linux-omap at vger.kernel.org>; James E.J. Bottomley <jejb at linux.vnet.ibm.com>; linux-scsi <linux-scsi at vger.kernel.org>; Takashi Iwai <tiwai at suse.com>; Sebastian Ott <sebott at linux.vnet.ibm.com>; James Smart <james.smart at broadcom.com>; Cezary Jackiewicz <cezary.jackiewicz at gmail.com>; linux-serial at vger.kernel.org; Jiri Slaby <jslaby at suse.com>; Darren Hart <dvhart at infradead.org>; Zhang Rui <rui.zhang at intel.com>; Dick Kennedy <dick.kennedy at broadcom.com>; Mathias Nyman <mathias.nyman at intel.com>; Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>; Peter Oberparleiter <oberpar at linux.vnet.ibm.com>; intel-gfx at lists.freedesktop.org; Jani Nikula <jani.nikula at linux.intel.com>; Eduardo Valentin <edubezval at gmail.com>; Mark Brown <broonie at kernel.org>; Rodrigo Vivi <rodrigo.vivi at intel.com>; Platform Driver <platform-driver-x86 at vger.kernel.org>; Felipe Balbi <balbi at kernel.org>; Martin K. Petersen <martin.petersen at oracle.com>; Greg Kroah-Hartman <gregkh at linuxfoundation.org>; linux-pm at vger.kernel.org; USB <linux-usb at vger.kernel.org>; Liam Girdwood <lgirdwood at gmail.com>; linux-kernel at vger.kernel.org; Luis R. Rodriguez <mcgrof at kernel.org>; Andy Shevchenko <andy at infradead.org>; Martin Schwidefsky <schwidefsky at de.ibm.com>; Jarkko Nikula <jarkko.nikula at bitmer.com>
Subject: Re: [alsa-devel] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

On Tue, Dec 19, 2017 at 8:15 PM, Joe Perches <joe at perches.com> wrote:
> Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
> Done with perl script:
> $ git grep -w --name-only DEVICE_ATTR | \
>   xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(\s*S_IRUGO\s*\|\s*S_IWUSR|\s*S_IWUSR\s*\|\s*S_IRUGO\s*|\s*0644\s*)\)?\s*,\s*\1_show\s*,\s*\1_store\s*\)/DEVICE_ATTR_RW(\1)/g; print;}'

>  drivers/platform/x86/compal-laptop.c | 18 +++++----------

> --- a/drivers/platform/x86/compal-laptop.c
> +++ b/drivers/platform/x86/compal-laptop.c
> @@ -679,18 +679,12 @@ static int bat_writeable_property(struct 
> power_supply *psy,
>  /* ============== */
>  /* Driver Globals */
>  /* ============== */
> -static DEVICE_ATTR(wake_up_pme,
> -               0644, wake_up_pme_show,         wake_up_pme_store);
> -static DEVICE_ATTR(wake_up_modem,
> -               0644, wake_up_modem_show,       wake_up_modem_store);
> -static DEVICE_ATTR(wake_up_lan,
> -               0644, wake_up_lan_show, wake_up_lan_store);
> -static DEVICE_ATTR(wake_up_wlan,
> -               0644, wake_up_wlan_show,        wake_up_wlan_store);
> -static DEVICE_ATTR(wake_up_key,
> -               0644, wake_up_key_show, wake_up_key_store);
> -static DEVICE_ATTR(wake_up_mouse,
> -               0644, wake_up_mouse_show,       wake_up_mouse_store);
> +static DEVICE_ATTR_RW(wake_up_pme);
> +static DEVICE_ATTR_RW(wake_up_modem); static 
> +DEVICE_ATTR_RW(wake_up_lan); static DEVICE_ATTR_RW(wake_up_wlan); 
> +static DEVICE_ATTR_RW(wake_up_key); static 
> +DEVICE_ATTR_RW(wake_up_mouse);

Acked-by: Andy Shevchenko <andy.shevchenko at gmail.com>

for PDx86 bits.

Have to say that while it doesn't change the attributes here, it might require still to be revisited by security people, if they wish.

With Best Regards,
Andy Shevchenko
Alsa-devel mailing list
Alsa-devel at alsa-project.org

More information about the dri-devel mailing list