[PATCH] drm/sun4i: hdmi: Fix sun4i_tmds_determine_rate

Maxime Ripard maxime.ripard at free-electrons.com
Thu Dec 21 12:48:44 UTC 2017


On Thu, Dec 21, 2017 at 10:24:11PM +1100, Jonathan Liu wrote:
> There are several issues in sun4i_tmds_determine_rate:
> - doesn't check if the best match was already set before comparing it
>   with the enumerated parameters which could result in integer divide
>   by zero
> - doesn't consider rate halving when determining closest match if it
>   can't match the requested rate exactly
> - sets best_div to i which corresponds to rate halving when it should be
>   set to j which corresponds to the divider
> Fix these issues.
> Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support")
> Signed-off-by: Jonathan Liu <net147 at gmail.com>

Please make separate patches for each of these issues, if possible
detailing how do you reproduce them.


Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20171221/555a6fd4/attachment.sig>

More information about the dri-devel mailing list