[PATCH 2/3] drm/panel: Add Ilitek ILI9322 driver

[Linus Walleij]

On Thu, Dec 21, 2017 at 3:15 PM, Thierry Reding
<thierry.reding at gmail.com> wrote:

> checkpatch.pl gives me these:
>
>         -:30: WARNING: please write a paragraph that describes the config symbol fully
>         #30: FILE: drivers/gpu/drm/panel/Kconfig:31:
>         +config DRM_PANEL_ILITEK_IL9322

I don't understand this because there is a blurb. I have had this
false positive before.

>         -:54: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>         #54:
>         new file mode 100644

Skipping as agreed.

>         -:130: CHECK: Prefer using the BIT macro
>         #130: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:72:
>         +#define ILI9322_ENTRY_PAL              (1 << 2)
>
>         -:134: CHECK: Prefer using the BIT macro
>         #134: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:76:
>         +#define ILI9322_ENTRY_SERIAL_RGB_ALIGNED (1 << 4)

These are bananas because checkpatch doesn't understand
context. They are actually bitfields with the first bit set.

>         -:196: CHECK: spaces preferred around that '|' (ctx:VxV)
>         #196: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:138:
>         +#define ILI9322_IF_CTRL_SYNC_DISABLED  (BIT(2)|BIT(3))

I didn't get this warning, wonder why. Fixed it anyways.

>         -:551: WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
>         #551: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:493:
>         +       msleep(10);

It's fine if it takes 20 or 90 ms so I chose to just ignore it. It's not on
any critical path.

Yours,
Linus Walleij