[PATCH v3 00/27] kill devm_ioremap_nocache
linux at roeck-us.net
Sat Dec 23 15:57:40 UTC 2017
On 12/23/2017 05:48 AM, Greg KH wrote:
> On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote:
>> Hi all,
>> When I tried to use devm_ioremap function and review related code, I found
>> devm_ioremap and devm_ioremap_nocache is almost the same with each other,
>> except one use ioremap while the other use ioremap_nocache.
> For all arches? Really? Look at MIPS, and x86, they have different
Both mips and x86 end up mapping the same function, but other arches don't.
mn10300 is one where ioremap and ioremap_nocache are definitely different.
>> While ioremap's
>> default function is ioremap_nocache, so devm_ioremap_nocache also have the
>> same function with devm_ioremap, which can just be killed to reduce the size
>> of devres.o(from 20304 bytes to 18992 bytes in my compile environment).
>> I have posted two versions, which use macro instead of function for
>> devm_ioremap_nocache or devm_ioremap. And Greg suggest me to kill
>> devm_ioremap_nocache for no need to keep a macro around for the duplicate
>> thing. So here comes v3 and please help to review.
> I don't think this can be done, what am I missing? These functions are
> not identical, sorry for missing that before.
> greg k-h
More information about the dri-devel