答复: [PATCH] drm/amdgpu/virt: fix double kfree on bo_va

[Liu, Monk]

thanks for this catch!


Reviewed-by: Monk Liu <monk.liu at amd.com>

________________________________
发件人: Colin King <colin.king at canonical.com>
发送时间: 2017年2月4日 4:23:42
收件人: Deucher, Alexander; Koenig, Christian; David Airlie; Liu, Monk; Yu, Xiangliang; amd-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org
抄送: kernel-janitors at vger.kernel.org; linux-kernel at vger.kernel.org
主题: [PATCH] drm/amdgpu/virt: fix double kfree on bo_va

From: Colin Ian King <colin.king at canonical.com>

bo_va is being kfree'd twice, once in the call to amdgpu_vm_bo_rmv
and then a short while later. Fix this double free by removing
the 2nd kfree.

Detected by CoverityScan, CID#1399524 ("Double Free")

Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 3fd951c..dcfb7df 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -83,7 +83,6 @@ int amdgpu_map_static_csa(struct amdgpu_device *adev, struct amdgpu_vm *vm)
                 DRM_ERROR("failed to do bo_map on static CSA, err=%d\n", r);
                 amdgpu_vm_bo_rmv(adev, bo_va);
                 ttm_eu_backoff_reservation(&ticket, &list);
-               kfree(bo_va);
                 return r;
         }

--
2.10.2

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170204/2c7ed346/attachment.html>