[PATCH v3 12/23] drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs

Philipp Zabel p.zabel at pengutronix.de
Tue Feb 7 10:10:04 UTC 2017


Hi Shawn,

On Tue, 2017-02-07 at 17:16 +0800, Shawn Guo wrote:
> From: Shawn Guo <shawn.guo at linaro.org>
> 
> With the vblank hooks in struct drm_crtc_funcs, we do not need to
> maintain the CRTC specific vblank callbacks with struct
> imx_drm_crtc_helper_funcs any more.  By moving the stuff that we
> currently do in imx_drm_add_crtc(), like of_node setting and
> drm_crtc_helper_add()/drm_crtc_init_with_planes() invoking, we can kill
> things like struct imx_drm_crtc, imx_drm_crtc_helper_funcs and related
> functions completely.

Thanks for removing the imx_drm_crtc indirection.

> Functions ipu_enable_vblank() and ipu_disable_vblank() are moved around
> without changes, only for saving the forward declarations.
> 
> Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
> Cc: Philipp Zabel <p.zabel at pengutronix.de>

Acked-by: Philipp Zabel <p.zabel at pengutronix.de>

regards
Philipp



More information about the dri-devel mailing list