[PATCH] drm: mxsfb_crtc: Fix the framebuffer misplacement

Daniel Vetter daniel at ffwll.ch
Tue Feb 7 22:15:37 UTC 2017


On Tue, Feb 07, 2017 at 10:44:59PM +0100, Marek Vasut wrote:
> On 02/02/2017 10:26 PM, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam at nxp.com>
> > 
> > Currently the framebuffer content is displayed with incorrect offsets
> > in both the vertical and horizontal directions.
> > 
> > The fbdev version of the driver does not show this problem. Breno Lima
> > dumped the eLCDIF controller registers on both the drm and fbdev drivers
> > and noticed that the VDCTRL3 register is configured incorrectly in the
> > drm driver.
> > 
> > The fbdev driver calculates the vertical and horizontal wait counts
> > of the VDCTRL3 register by doing: back porch + sync length.
> > 
> > Looking at the horizontal and vertical timing diagram from 
> > include/drm/drm_modes.h this value corresponds to:
> > 
> > crtc_[hv]total - crtc_[hv]sync_start
> > 
> > So fix the VDCTRL3 register setting accordingly so that the eLCDIF
> > controller can properly show the framebuffer content in the correct
> > position.
> > 
> > Reported-by: Breno Lima <breno.lima at nxp.com>
> > Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
> 
> Tested-by: Marek Vasut <marex at denx.de>

You're listed as maintainer in MAINTAINERS, replying with tested-by is
super confusing. Did you pick this up and will do a pull request? Do you
expect someone else to pick this up?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list