[PATCH] drm: mxsfb_crtc: Fix the framebuffer misplacement

[Daniel Vetter]

On Tue, Feb 7, 2017 at 11:31 PM, Marek Vasut <marex at denx.de> wrote:
> On 02/07/2017 11:15 PM, Daniel Vetter wrote:
>> On Tue, Feb 07, 2017 at 10:44:59PM +0100, Marek Vasut wrote:
>>> On 02/02/2017 10:26 PM, Fabio Estevam wrote:
>>>> From: Fabio Estevam <fabio.estevam at nxp.com>
>>>>
>>>> Currently the framebuffer content is displayed with incorrect offsets
>>>> in both the vertical and horizontal directions.
>>>>
>>>> The fbdev version of the driver does not show this problem. Breno Lima
>>>> dumped the eLCDIF controller registers on both the drm and fbdev drivers
>>>> and noticed that the VDCTRL3 register is configured incorrectly in the
>>>> drm driver.
>>>>
>>>> The fbdev driver calculates the vertical and horizontal wait counts
>>>> of the VDCTRL3 register by doing: back porch + sync length.
>>>>
>>>> Looking at the horizontal and vertical timing diagram from
>>>> include/drm/drm_modes.h this value corresponds to:
>>>>
>>>> crtc_[hv]total - crtc_[hv]sync_start
>>>>
>>>> So fix the VDCTRL3 register setting accordingly so that the eLCDIF
>>>> controller can properly show the framebuffer content in the correct
>>>> position.
>>>>
>>>> Reported-by: Breno Lima <breno.lima at nxp.com>
>>>> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
>>>
>>> Tested-by: Marek Vasut <marex at denx.de>
>>
>> You're listed as maintainer in MAINTAINERS, replying with tested-by is
>> super confusing. Did you pick this up and will do a pull request?
>
> No
>
>> Do you expect someone else to pick this up?
>
> The last patches for mxsfb were picked by you, but if you expect me to
> pick the mxsfb patches through my own tree and then submit PR, I can do
> that.

I apply trivial patches as a welcoming gesture for new folks, but
that's generally about it. Anyway, if you expect drm-misc maintainers
to pick up stuff then you need to tell us, otherwise the patch will be
lost. But then if you want mxsfb maintained in drm-misc I'd say better
to get commit rights and join the club :-) Just ping on #dri-devel on
freenode.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch