[PATCH v3 1/7] drm/atomic: Add new iterators over all state, v3.
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Sun Feb 12 12:13:42 UTC 2017
Hi Maarten,
Thank you for the patch.
On Monday 16 Jan 2017 10:37:38 Maarten Lankhorst wrote:
> Add for_each_(old)(new)_(plane,connector,crtc)_in_state iterators to
> replace the old for_each_xxx_in_state ones. This is useful for >1 flip
> depth and getting rid of all xxx->state dereferences.
>
> This requires extra fixups done when committing a state after
> duplicating, which in general isn't valid but is used by suspend/resume.
> To handle these, introduce drm_atomic_helper_commit_duplicated_state
> which performs those fixups before checking & committing the state.
>
> Changes since v1:
> - Remove nonblock parameter for commit_duplicated_state.
> Changes since v2:
> - Use commit_duplicated_state for i915 load detection.
> - Add WARN_ON(old_state != obj->state) before swapping.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> drivers/gpu/drm/drm_atomic.c | 6 +++
> drivers/gpu/drm/drm_atomic_helper.c | 65 +++++++++++++++++++++++++----
> drivers/gpu/drm/i915/intel_display.c | 13 +++---
> include/drm/drm_atomic.h | 81 +++++++++++++++++++++++++++++++--
> include/drm/drm_atomic_helper.h | 2 +
> 5 files changed, 149 insertions(+), 18 deletions(-)
--
Regards,
Laurent Pinchart
More information about the dri-devel
mailing list