[radeon-alex:drm-next-4.12-wip 34/40] drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:620:4: warning: left shift count >= width of type
Zhang, Jerry
Jerry.Zhang at amd.com
Mon Feb 13 01:43:28 UTC 2017
Hi Christian,
Maybe we need a change.
{{{
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
index 4d26e9b..fb5448b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h
@@ -65,7 +65,7 @@
#define AMDGPU_PTE_FRAG(x) ((x & 0x1f) << 7)
-#define AMDGPU_PTE_PRT (1UL << 63)
+#define AMDGPU_PTE_PRT (1ULL << 63)
/* How to programm VM fault handling */
#define AMDGPU_VM_FAULT_STOP_NEVER 0
}}}
Regards,
Jerry (Junwei Zhang)
Linux Base Graphics
SRDC Software Development
_____________________________________
From: Christian König [mailto:deathsimple at vodafone.de]
Sent: Saturday, February 11, 2017 15:56
To: Zhang, Jerry
Cc: Deucher, Alexander; Haehnle, Nicolai; dri-devel at lists.freedesktop.org; Koenig, Christian
Subject: Re: [radeon-alex:drm-next-4.12-wip 34/40] drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:620:4: warning: left shift count >= width of type
Mhm, guys any idea why the build bot is spamming us with that warning?
The type is 64bit and the shift is 63, so that should work fine.
Regards,
Christian.
Am 10.02.2017 um 20:48 schrieb kbuild test robot:
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.12-wip
head: d32ff0ea8e22964abcc6406e00a0646f2bfb94c7
commit: 382a21d981661dbc8198c37dc95707e1e381ce76 [34/40] drm/amdgpu: IOCTL interface for PRT support v4
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 382a21d981661dbc8198c37dc95707e1e381ce76
# save the attached .config to linux build tree
make.cross ARCH=xtensa
All warnings (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c: In function 'amdgpu_gem_va_ioctl':
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:620:4: warning: left shift count >= width of type
va_flags |= AMDGPU_PTE_PRT;
^
vim +620 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
604 r = -ENOENT;
605 goto error_backoff;
606 }
607 } else {
608 bo_va = fpriv->prt_va;
609 }
610
611 switch (args->operation) {
612 case AMDGPU_VA_OP_MAP:
613 if (args->flags & AMDGPU_VM_PAGE_READABLE)
614 va_flags |= AMDGPU_PTE_READABLE;
615 if (args->flags & AMDGPU_VM_PAGE_WRITEABLE)
616 va_flags |= AMDGPU_PTE_WRITEABLE;
617 if (args->flags & AMDGPU_VM_PAGE_EXECUTABLE)
618 va_flags |= AMDGPU_PTE_EXECUTABLE;
619 if (args->flags & AMDGPU_VM_PAGE_PRT)
> 620 va_flags |= AMDGPU_PTE_PRT;
621 r = amdgpu_vm_bo_map(adev, bo_va, args->va_address,
622 args->offset_in_bo, args->map_size,
623 va_flags);
624 break;
625 case AMDGPU_VA_OP_UNMAP:
626 r = amdgpu_vm_bo_unmap(adev, bo_va, args->va_address);
627 break;
628 default:
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel at lists.freedesktop.org<mailto:dri-devel at lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/dri-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170213/e71654f1/attachment-0001.html>
More information about the dri-devel
mailing list