[PATCH] drm: add drm_get_connector_force_name

Chris Wilson chris at chris-wilson.co.uk
Fri Feb 17 15:26:40 UTC 2017


On Fri, Feb 17, 2017 at 05:14:47PM +0200, Jani Nikula wrote:
> Follow the naming in debugfs also for logging, add "unknown" for values
> beyond the enumerated ones.
> 
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---

> +EXPORT_SYMBOL(drm_get_connector_force_name);

Do we need the symbol outside of drm-core? Mainly asking if you forsee a
user.

> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index 2290a74a6e46..a6385d4b598b 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -261,30 +261,8 @@ int drm_debugfs_cleanup(struct drm_minor *minor)
>  static int connector_show(struct seq_file *m, void *data)
>  {
> -	seq_puts(m, status);
> +	seq_puts(m, drm_get_connector_force_name(connector->force));

Loses the trailing '\n'. It's not required, but it looks neater on the
terminal.

Two small questions,
Reviwed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the dri-devel mailing list