[PATCH 6/9] drm/ast: Factor mmc_test code in POST code

Emil Velikov emil.l.velikov at gmail.com
Sat Feb 18 15:28:44 UTC 2017


On 17 February 2017 at 05:32, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
> There's a lot of duplication for what's essentially N copies of
> the same loop, so factor it. The upcoming AST2500 POST code adds
> more of this.
>
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>

Here is where things go fun:

Original code does the following data flexing only for the mmc_*test2
code, while this patch adds it to both test and test2.

       data = ast_mindwm(...);
       data = (data | (data >> 16)) & 0xffff;
//       ast_moutdwm(...);
       return data;

Afaict you have addressed that in the github branch/patch so things
are back to normal.
Tests are still a bit magical but not much you can/should do about it.

Regards,
Emil


More information about the dri-devel mailing list