[PATCH] drm/atomic: Add target_vblank support in atomic helpers.

[Daniel Vetter]

On Wed, Jan 04, 2017 at 04:36:50PM +0000, Grodzovsky, Andrey wrote:
> > > +/**
> > > + * drm_atomic_helper_page_flip - execute a legacy page flip
> > > + * @crtc: DRM crtc
> > > + * @fb: DRM framebuffer
> > > + * @event: optional DRM event to signal upon completion
> > > + * @flags: flip flags for non-vblank sync'ed updates
> > > + *
> > > + * Provides a default page flip on specific vblank implementation
> > > +using
> > > + * the atomic driver interface.
> > > + *
> > > + * Note that for now so called async page flips (i.e. updates which
> > > +are not
> > > + * synchronized to vblank) are not supported, since the atomic
> > > +interfaces have
> > > + * no provisions for this yet.
> > > + *
> > > + * Returns:
> > > + * Returns 0 on success, negative errno numbers on failure.
> > 
> > Kerneldoc isn't updated, just verbatim copypaste. Please also linke these
> > 2 functions. And if you have time, would be good to sprinkle links to the
> 
> Not sure here, do you mean kerneldoc is not generated for the new helper function ? If so ,
> Is it because @tags are missing ?

You should get a warning about the missing @tag, yes. But having the exact
same text for both is pointless, so for similar functions it's good to
highlight the differences (and mabye link between the two using the
functions() syntax).
> 
> > vfunc hooks for each of these default helpers (they're unfortunately missing
> > ...), e.g. here &drm_crtc_funcs.page_flip_target.
> 
> Do you mean adding kernedoc for the vfunc hook ?

No, just linking to them.

http://blog.ffwll.ch/2016/12/howto-docs.html

and you can see the output, makes all this a bit easier to understand
probably.
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch