[PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

[Andi Shyti]

Hi Inki,

Thanks for the reply, but...

> >> +static const struct drm_display_mode default_mode = {
> >> +	.clock = 222372,
> >> +	.hdisplay = 1440,
> >> +	.hsync_start = 1440 + 1,
> >> +	.hsync_end = 1440 + 1 + 1,
> >> +	.htotal = 1440 + 1 + 1 + 1,
> >> +	.vdisplay = 2560,
> >> +	.vsync_start = 2560 + 1,
> >> +	.vsync_end = 2560 + 1 + 1,
> >> +	.vtotal = 2560 + 1 + 1 + 15,
> >> +	.vrefresh = 60,
> >> +	.flags = 0,
> >> +};
> > 
> > how is this working with tm2e? Are these values valid for both
> > the boards?
> 
> We don't need to consider tm2e board with two reasones,
> 1. there is no tm2e board support in mainline
> 2. the panel on tm2 would be a little bit different from one on tm2e

... this display in the Tizen Kernel is supported by both:
tm2 [1] and tm2e [2]. The only differences are:

TM2:
   clock-frequency = <14874444>;
   hactive = <1440>;

TM2E:
   clock-frequency = <16523724>;
   hactive = <1600>;

I don't know much about the differences you mention in point 2,
but it's a pity to drop support only because we don't want to put
in the dts the 'hactive', and 'clock-frequency' properties.

Andi

[1] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts?h=tizen#n1284
[2] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts?h=tizen#n1270