[PATCH] drm/amdgpu/gfx8: fix bugon.cocci warnings

Yu, Xiangliang Xiangliang.Yu at amd.com
Tue Jan 10 09:38:15 UTC 2017


>  Use BUG_ON instead of a if condition followed by BUG.
> 
> Generated by: scripts/coccinelle/misc/bugon.cocci
> 
> CC: Xiangliang Yu <Xiangliang.Yu at amd.com>
> Signed-off-by: Julia Lawall <julia.lawall at lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
> ---
> 
>  gfx_v8_0.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -6623,8 +6623,7 @@ static void gfx_v8_0_ring_emit_fence_kiq
>  					 u64 seq, unsigned int flags)
>  {
>  	/* we only allocate 32bit for each seq wb address */
> -	if (flags & AMDGPU_FENCE_FLAG_64BIT)
> -		BUG();
> +	BUG_ON(flags & AMDGPU_FENCE_FLAG_64BIT);
> 
>  	/* write fence seq to the "addr" */
>  	amdgpu_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3));

Reviewd-by: Xiangliang.Yu <Xiangliang.Yu at amd.com>



More information about the dri-devel mailing list