[Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

Rob Clark robdclark at gmail.com
Thu Jan 12 01:43:16 UTC 2017


On Wed, Jan 11, 2017 at 7:51 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
>
> +struct drm_format_modifier {
> +       /* Bitmask of formats in get_plane format list this info
> +        * applies to. */
> +       uint64_t formats;

re: the uabi, I'd suggest to at least make this 'u32 offset; u32
formats'.. we can keep the existing implementation in this patch and
always set 'offset' to zero, and let the first one to hit more than 32
formats deal with the implementation.  (Maybe a strategically placed
WARN_ON() if you go that route..)

Otherwise I guess it is just a couple years until getplane3 ;-)

BR,
-R

> +
> +       /* This modifier can be used with the format for this plane. */
> +       uint64_t modifier;
> +};


More information about the dri-devel mailing list