[PATCH 4/5] drm/omap: Stop using drm_framebuffer_unregister_private

[Laurent Pinchart]

Hi Daniel,

Thank you for the patch.

On Tuesday 27 Dec 2016 11:49:24 Daniel Vetter wrote:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But omapdrm is using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.
> 
> Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_fbdev.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> b/drivers/gpu/drm/omapdrm/omap_fbdev.c index aed99a0fc44b..2a839956dae6
> 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -225,10 +225,8 @@ static int omap_fbdev_create(struct drm_fb_helper
> *helper,
> 
>  		drm_fb_helper_release_fbi(helper);
> 
> -		if (fb) {
> -			drm_framebuffer_unregister_private(fb);
> +		if (fb)
>  			drm_framebuffer_remove(fb);
> -		}
>  	}
> 
>  	return ret;
> @@ -314,10 +312,8 @@ void omap_fbdev_free(struct drm_device *dev)
>  	omap_gem_put_paddr(fbdev->bo);
> 
>  	/* this will free the backing object */
> -	if (fbdev->fb) {
> -		drm_framebuffer_unregister_private(fbdev->fb);
> +	if (fbdev->fb)
>  		drm_framebuffer_remove(fbdev->fb);
> -	}
> 
>  	kfree(fbdev);

-- 
Regards,

Laurent Pinchart