[PATCH 5/5] drm/tegra: Stop using drm_framebuffer_unregister_private
Thierry Reding
thierry.reding at gmail.com
Thu Jan 12 14:37:40 UTC 2017
On Tue, Dec 27, 2016 at 11:49:25AM +0100, Daniel Vetter wrote:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But tegra is using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.
Nit: "Tegra", "redundant", "FB"?
>
> One caveat here is that the failur path in the init code still
"failure"
> manually cleaned up the fb. I presume that was an oversigth and
"oversight"
> changed it over to drm_framebuffer_remove too.
>
> Cc: Thierry Reding <thierry.reding at gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
> drivers/gpu/drm/tegra/fb.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Yes, drm_framebuffer_remove() ends up calling tegra_fb_destroy(), which
is really what we need here, so:
Acked-by: Thierry Reding <treding at nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20170112/a817693a/attachment.sig>
More information about the dri-devel
mailing list