[PATCH v2] drm/exynos/decon5433: set STANDALONE_UPDATE_F also if planes are disabled

Joonyoung Shim jy0922.shim at samsung.com
Fri Jan 13 08:55:53 UTC 2017


Hi Andrzej,

On 01/13/2017 05:42 PM, Andrzej Hajda wrote:
> @@ -339,8 +342,10 @@ static void decon_atomic_flush(struct exynos_drm_crtc *crtc)
>  		decon_shadow_protect_win(ctx, i, false);
>  
>  	/* update iff there are active windows */
> -	if (crtc->base.state->plane_mask)
> +	if (test_bit(BIT_REQUEST_UPDATE, &ctx->flags)) {

It's better to just use test_and_clear_bit?

>  		decon_set_bits(ctx, DECON_UPDATE, STANDALONE_UPDATE_F, ~0);
> +		clear_bit(BIT_REQUEST_UPDATE, &ctx->flags);
> +	}
>  
>  	if (ctx->out_type & IFTYPE_I80)
>  		set_bit(BIT_WIN_UPDATED, &ctx->flags);
> 

I tested on TM2E board,

Tested-by: Joonyoung Shim <jy0922.shim at samsung.com>

Thanks.


More information about the dri-devel mailing list