Why does OUT_FENCE_PTR point not to an fd (s32) but to an s64?

Chad Versace chadversary at chromium.org
Fri Jan 13 21:31:19 UTC 2017


On Thu 12 Jan 2017, Gustavo Padovan wrote:
> 2017-01-12 Laurent Pinchart <laurent.pinchart at ideasonboard.com>:
> 
> > Hi Daniel,
> > 
> > On Thursday 12 Jan 2017 20:26:40 Daniel Vetter wrote:
> > > On Thu, Jan 12, 2017 at 05:17:26PM -0200, Gustavo Padovan wrote:
> > > > 2017-01-10 Laurent Pinchart <laurent.pinchart at ideasonboard.com>:
> > > >> On Monday 09 Jan 2017 11:23:23 Daniel Vetter wrote:
> > > >>> On Fri, Jan 06, 2017 at 01:04:55PM -0800, Chad Versace wrote:
> > > >>>> Was this a mistake in the API? If so, can we fix this ABI mistake
> > > >>>> before kernel consumers rely on this?

[...]

> I'd expect users defining an int and hitting the issue Chad hit instead
> of going to long types. So I hope we are safe here. I'll prepare a
> patch to make it s32.

Thanks for fixing this. I'm glad we caught it before the uabi became
frozen.


More information about the dri-devel mailing list